Skip to content

Conversation

dmytrotsko
Copy link
Collaborator

  • Removed all unused static files
  • Fixed typo in Signal field name (severenity_pyramid_rungs -> severenity_pyramid_rungs)
  • Fixed Category import for Signals
  • Fixed not displayed fields in admin view for Signals
  • Added filters description fixtures
  • Displayed few more fields on Signal Detailed View page

Copy link
Collaborator

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory review from me is 👍 so we can be prepped for early Monday merge and staging evaluation.

@melange396
Copy link
Collaborator

oh man, this is a huge diff! anything we should be looking for in particular?

@dmytrotsko
Copy link
Collaborator Author

oh man, this is a huge diff! anything we should be looking for in particular?

I don't think so. Just removed old unused stuff, few small fixes.
My idea was to merge this today to the staging branch to check how that works there.
But in general it should not break anything.

@dmytrotsko dmytrotsko merged commit 62f738c into staging Jul 29, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants