Skip to content

d3 upgrade #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

d3 upgrade #35

merged 2 commits into from
Oct 6, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Oct 5, 2022 •
edited by krivard
Loading

closes

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

fixed version of #31

@sgratzl sgratzl requested a review from krivard October 5, 2022 02:45
@sgratzl sgratzl added the chore label Oct 5, 2022
@sgratzl sgratzl self-assigned this Oct 5, 2022
@netlify
Copy link

netlify bot commented Oct 5, 2022

✅ Deploy Preview for cmu-delphi-covidcast-classic ready!

Name Link
🔨 Latest commit f4108e7
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast-classic/deploys/633cefda2b992200080b98b0
😎 Deploy Preview https://deploy-preview-35--cmu-delphi-covidcast-classic.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

krivard
krivard approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@krivard krivard merged commit 6d2bf9b into dev Oct 6, 2022
@krivard krivard deleted the sgratzl/d3-upgrade branch October 6, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees

@sgratzl sgratzl

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @krivard