Skip to content

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Aug 7, 2024

Closes #44, closes #46:

  • The autofitting feature added in Upgrade EpiVis dashboard #36 has been turned into a new navigation mode, which is enabled by default.
    • It is mutually exclusive with pan, scroll or crop modes - so once a user looks at a particular area of the chart, enabling or disabling signals will no longer reset their viewport.
    • Adding a new signal will reset the mode to "autofit" again.
  • The "Scale by 1/mean" and "Reset Dataset Scaling" buttons are moved into their own group, and given more appropriate icons. Also, navigation mode icons are now positioned on the top left of the screen.
  • The introductory interactive tour has been re-ordered so that top menu items are explained first.

@rzats rzats requested review from dshemetov and melange396 and removed request for dshemetov August 8, 2024 12:26
@melange396 melange396 changed the title Improve top panel elements Improve top panel elements & autofit mode Aug 14, 2024
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, and the new mode works well! Ive got just a few comments on presentation...

@rzats rzats requested a review from melange396 August 16, 2024 12:12
@rzats
Copy link
Contributor Author

rzats commented Aug 16, 2024

@melange396 updated!

@melange396 melange396 merged commit 430a6b3 into dev Aug 22, 2024
6 checks passed
@melange396 melange396 deleted the rzatserkovnyi/top-panel branch August 22, 2024 17:35
@melange396 melange396 mentioned this pull request Aug 22, 2024
@melange396
Copy link
Contributor

@rzats sorry i missed this before, but we should take out this redundant "f" key (Fit) action thats been replaced by the "a" key (Autofit) action introduced in this pr: https://github.com/cmu-delphi/www-epivis/pull/54/files#diff-15c9be2e78f911b6044c296ac349b7b39aa91dc78f2c499b918f570c0990a164R52-R56

@rzats rzats mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make "Scale by 1/mean" toggleable Make "autofit" a proper mode
2 participants