Skip to content

About page updates #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 5, 2023
Merged

About page updates #899

merged 7 commits into from
Dec 5, 2023

Conversation

carlynvandyke
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit babd136
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/656fa60602f3490008d4a4ac
😎 Deploy Preview https://deploy-preview-899--cmu-delphi-main.netlify.app/about
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

melange396
melange396 reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though i found a few formatting nits. There are also two instances where you use "data" as a plural noun ("These data") where i wouldve used a singular ("This data"), but your usage is not wrong and its really just a preference point these days.

melange396
melange396 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melange396 melange396 merged commit 98bb347 into dev Dec 5, 2023
@melange396 melange396 deleted the about-page-updates branch December 5, 2023 22:54
@melange396 melange396 mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

@rlunde rlunde Awaiting requested review from rlunde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlynvandyke @melange396