Skip to content

Code cleanup #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

Code cleanup #223

merged 1 commit into from
Sep 2, 2024

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Aug 9, 2024

Fixed VSCode(gopls check) warnings:

$ find . -name \*.go | xargs gopls check
cmd/cdi/cmd/cdi-api.go:287:25-39: unused parameter: spec
cmd/cdi/cmd/cdi-api.go:287:41-53: unused parameter: verbose
pkg/cdi/spec-dirs_test.go:230:20-32: unused parameter: t [windows]
pkg/cdi/spec-dirs_test.go:230:20-32: unused parameter: t
pkg/cdi/spec-dirs_test.go:189:4: ineffectual assignment to err

elezar
elezar approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bart0sh
Code cleanup
2c9b18b 
Fixed VSCode(gopls check) warnings.

Signed-off-by: Ed Bartosh <[email protected]>
@bart0sh bart0sh force-pushed the PR023-fix-gopls-findings branch from a24a0df to 2c9b18b Compare August 27, 2024 21:30
@bart0sh
Copy link
Contributor Author

bart0sh commented Aug 27, 2024

@elezar fixed CI failure. PTAL again, thanks!

elezar
elezar reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment •
edited by bart0sh
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear how the changes here caused the tests to fail and why this fix is required. Do you have an explaination?

Sure, I have. Adding require.NoError(t, err) triggered the failure as errors are not unexpected for this test. Removal of this fixed the test.

@bart0sh bart0sh mentioned this pull request Sep 2, 2024
Closed
18 tasks
@bart0sh
Copy link
Contributor Author

bart0sh commented Sep 2, 2024

@klihub Can you review & merge?

@klihub
Copy link
Contributor

klihub commented Sep 2, 2024

@klihub Can you review & merge?

Just a sec. Lemme skim through it...

@klihub klihub merged commit 91c77d0 into cncf-tags:main Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar approved these changes

@klihub klihub klihub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bart0sh @klihub @elezar