Bump version to v1.0.0 #260
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ require ( | |
| github.com/spf13/cobra v1.6.0 | ||
| gopkg.in/yaml.v2 v2.4.0 | ||
| sigs.k8s.io/yaml v1.3.0 | ||
| tags.cncf.io/container-device-interface v1.0.0 | ||
| tags.cncf.io/container-device-interface/schema v0.0.0 | ||
|
There was a problem hiding this comment. Question: Do we want to also specify a version for this? There was a problem hiding this comment. brougth both changes back as reverting them resulted in CI failures: https://github.com/cncf-tags/container-device-interface/actions/runs/13724737021 |
||
| ) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More a comment on the release process: These are probably not strictly necessary since these CLIs are not generally consumed externally, but it's probably more consistent to have them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same. We anyway have the replace rule, so the version here has no effect, but if we bump it now, we should always go through the motions for consistency. @bart0sh So wouldn't leaving this at
0.0.0be easier and less of a burden for maintenance ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.