This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Support running build:preview locally #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-double-u
previously approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Updated build:preview builds (but doesn't serve) locally,
Deploy preview looks good (https://deploy-preview-105--cncf-hugo-starter.netlify.app/),
Build logs look good (https://app.netlify.com/sites/cncf-hugo-starter/deploys/6102bd3b54759e0007abda1f)
/lgtm
|
Needs DCO before we can merge. |
Signed-off-by: Patrice Chalin <[email protected]>
chalin
force-pushed
the
chalin-local-build-preview-2021-07-29
branch
from
a9364a6 to
3924c2e
Compare
|
Thanks for all the checks! |
Sigh. Having only contributed to projects using CLA, I keep forgetting to sign. 🤷 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a default value for
DEPLOY_PRIME_URL(which isn't set when we run locally) -- otherwise the script just fails.