build: upgrade to go1.10.3 #27597
Merged
build: upgrade to go1.10.3 #27597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
go1.10 has a bug in its test2json tool that causes test names with colons in them to be misparsed (golang/go#23920). This was causing the nightly stress issue poster to incorrectly post dozens of issues about tests that had not actually failed. Upgrade the builder to go1.10.3, which includes a fix for the test2json tool. Fix cockroachdb#27498. Release note: None
|
TFTR! Really excited to not have to clean up 50+ incorrect stress failures tonight. :) bors r=tschottdorf |
craig bot
pushed a commit
that referenced
this pull request
Jul 15, 2018
27597: build: upgrade to go1.10.3 r=tschottdorf a=benesch go1.10 has a bug in its test2json tool that causes test names with colons in them to be misparsed (golang/go#23920). This was causing the nightly stress issue poster to incorrectly post dozens of issues about tests that had not actually failed. Upgrade the builder to go1.10.3, which includes a fix for the test2json tool. Fix #27498. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go1.10 has a bug in its test2json tool that causes test names with colons in
them to be misparsed (golang/go#23920). This was causing the nightly stress
issue poster to incorrectly post dozens of issues about tests that had not
actually failed. Upgrade the builder to go1.10.3, which includes a fix for the
test2json tool.
Fix #27498.
Release note: None