build: require patch level 10+ for go1.12 #42474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of Go before 1.12.10 were more lenient in the URL format they were accepting. This was changed in 1.12.10 and CockroachDB tests were updated accordingly, but these tests will now fail when ran with older 1.12 versions. This patch enhances the version check to require a specific patch release. Release note (build change): Go version 1.12.10+ is now required to build CockroachDB successfully.
|
This change is |
tbg
approved these changes
Nov 14, 2019
|
tfyr bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 14, 2019
42474: build: require patch level 10+ for go1.12 r=knz a=knz Fixes #42229 Versions of Go before 1.12.10 were more lenient in the URL format they were accepting. This was changed in 1.12.10 and CockroachDB tests were updated accordingly, but these tests will now fail when ran with older 1.12 versions. This patch enhances the version check to require a specific patch release. Release note (build change): Go version 1.12.10+ is now required to build CockroachDB successfully. Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42229
Versions of Go before 1.12.10 were more lenient in the URL format they
were accepting. This was changed in 1.12.10 and CockroachDB tests were
updated accordingly, but these tests will now fail when ran with older
1.12 versions.
This patch enhances the version check to require a specific patch
release.
Release note (build change): Go version 1.12.10+ is now required to
build CockroachDB successfully.