Skip to content

bazel: in dev toolchain, don't include unnecessary directory #66012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

rickystewart
Copy link
Collaborator

After a macOS update, including the additional directory in the include
search path breaks as the same file is included in two different
locations, leading to some missing declarations.

Closes #64296.

Release note: None

After a macOS update, including the additional directory in the include
search path breaks as the same file is included in two different
locations, leading to some missing declarations.

Closes cockroachdb#64296.

Release note: None
@rickystewart rickystewart requested a review from rail June 2, 2021 21:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Jun 3, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 3, 2021

Build succeeded:

@craig craig bot merged commit 0f0c5d0 into cockroachdb:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: toolchain_dev_darwin_x86 broken after Big Sur/XCode update
3 participants