Skip to content

Update Go version requirement for building 21.1 from source #10489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021

Conversation

jseldess
Copy link
Contributor

@jseldess jseldess commented May 4, 2021

Technically, the minimum required is 1.15.3:
https://github.com/cockroachdb/cockroach/blob/release-21.1/build/go-version-check.sh#L10

However, 1.15.11 avoids these Go bugs:
golang/go#45076
golang/go#45187
golang/go#42884

So to prevent users from running into those, we listing
1.15.11 as the minimum required version, followed by
a note that you can use IGNORE_GOVERS=1 to try building
with older versions.

Fixes #10468
Fixes #9081

Technically, the minimum required is 1.15.3:
https://github.com/cockroachdb/cockroach/blob/release-21.1/build/go-version-check.sh#L10

However, 1.15.11 avoids these Go bugs:
golang/go#45076
golang/go#45187
golang/go#42884

So to prevent users from running into those, we listing
1.15.11 as the minimum required version, followed by
a note that you can use IGNORE_GOVERS=1 to try building
with older versions.

Fixes #10468
Fixes #9081
@jseldess jseldess requested a review from rickystewart May 4, 2021 02:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jseldess jseldess requested a review from otan May 4, 2021 02:08
@github-actions
Copy link

github-actions bot commented May 4, 2021

Files changed:

v21.1/install-cockroachdb-linux.html
v21.1/install-cockroachdb-mac.html

@jseldess jseldess removed the request for review from otan May 4, 2021 02:08
@netlify
Copy link

netlify bot commented May 4, 2021

Netlify Preview

Built with commit 094d7cd

https://deploy-preview-10489--cockroachdb-docs.netlify.app

@jseldess jseldess merged commit 1374052 into master May 4, 2021
@jseldess jseldess deleted the required-go-version branch May 4, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release-21.1: build: upgrade go to 1.15.11 build: upgrade to go 1.15.4
3 participants