Skip to content

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Sep 3, 2025

Fixes DOC-14019

  • In _data/v25.3/metrics/export, copied crdb_metrics.yaml, shared_metrics.yaml, and tenant_metrics.yaml from https://github.com/cockroachlabs/managed-service/tree/master/pkg/otel/assets.
  • In available-metrics-in-metrics-list.csv, added 6 rebalancing.* metrics from crdb_metrics.yaml.
  • In metric-names.md, modified to (a) use metrics.yaml for Description, Unit and Type, (b) use crdb_metrics.yaml, shared_metrics.yaml, and tenant_metrics.yaml for Supported Deployments.

Rendered preview

…cs.yaml, and tenant_metrics.yaml from https://github.com/cockroachlabs/managed-service/tree/master/pkg/otel/assets.

In available-metrics-in-metrics-list.csv, added 6 rebalancing.* metrics from crdb_metrics.yaml.

In metric-names.md, modified to (a) use metrics.yaml for Description, Unit and Type, (b) use crdb_metrics.yaml, shared_metrics.yaml, and tenant_metrics.yaml for Supported Deployments.
Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 5f69cf1
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68d6ba276ac0d40009122334

Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 5f69cf1
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68d6ba27627b1700080c1136

Copy link

github-actions bot commented Sep 3, 2025

Files changed:

@florence-crl florence-crl requested a review from mikeCRL September 3, 2025 22:16
Copy link

netlify bot commented Sep 3, 2025

Netlify Preview

Name Link
🔨 Latest commit 5f69cf1
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68d6ba2742f23c00084deed1
😎 Deploy Preview https://deploy-preview-20272--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florence-crl LGTM, per our discussion. Just one additional comment for your consideration.

@florence-crl florence-crl merged commit 2f33cae into main Sep 26, 2025
5 checks passed
@florence-crl florence-crl deleted the DOC-14019 branch September 26, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants