Skip to content

Conversation

jhlodin
Copy link
Contributor

@jhlodin jhlodin commented Sep 11, 2025

https://cockroachlabs.atlassian.net/browse/DOC-14812

Addressing instances in these pages and elsewhere deemed appropriate.

@jhlodin jhlodin requested a review from mikeCRL September 11, 2025 18:20
Copy link

github-actions bot commented Sep 11, 2025

Files changed:

Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit cbbfb8d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/68cc6e5e7023cb00088605b5

Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit cbbfb8d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/68cc6e5e1892410008c2759c

@jhlodin jhlodin marked this pull request as ready for review September 11, 2025 18:21
@jhlodin jhlodin requested a review from a team as a code owner September 11, 2025 18:21
Copy link

netlify bot commented Sep 11, 2025

Netlify Preview

Name Link
🔨 Latest commit cbbfb8d
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/68cc6e5eff2bda0008323ca5
😎 Deploy Preview https://deploy-preview-20328--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland self-requested a review September 15, 2025 20:53
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! all comments are just non-blocking suggestions or comments/thoughts about things that may be for other PRs


{{site.data.alerts.callout_info}}
To orchestrate a physically distributed cluster in production, see [Orchestrated Deployments]({% link {{ page.version.version }}/cockroachdb-operator-overview.md %}). To deploy a 30-day free CockroachDB {{ site.data.products.dedicated }} cluster instead of running CockroachDB yourself, see the [Quickstart]({% link cockroachcloud/quickstart.md %}).
To orchestrate a physically distributed cluster in production, see [Orchestrated Deployments]({% link {{ page.version.version }}/cockroachdb-operator-overview.md %}). To deploy a 30-day free CockroachDB {{ site.data.products.advanced }} cluster instead of running CockroachDB yourself, see the [Quickstart]({% link cockroachcloud/quickstart.md %}).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta: this "30-day free" may be wrong now (all free trial info appears to be here and refers to cloud credits), feel like we as a team need to have the DRY conversation in a more structured way.

idk if you feel like replacing these uses of "30-day free" in this PR to say "free trial" or if that should be another PR, let me know and i'll file an issue if the latter. Probably the latter is The Right Thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this is probably legacy language, but having already dealt with some of these politics I definitely want to run by PM before changing any free trial language

@jhlodin jhlodin enabled auto-merge (squash) September 18, 2025 20:41
@jhlodin jhlodin merged commit 90c8ede into main Sep 18, 2025
6 checks passed
@jhlodin jhlodin deleted the jl/doc-14812 branch September 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants