-
Notifications
You must be signed in to change notification settings - Fork 473
Clean up lingering post-24.2 uses of serverless/dedicated #20328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! all comments are just non-blocking suggestions or comments/thoughts about things that may be for other PRs
src/current/_includes/v24.3/userfile-examples/freetier-userfile-note.md
Outdated
Show resolved
Hide resolved
src/current/_includes/v25.1/userfile-examples/freetier-userfile-note.md
Outdated
Show resolved
Hide resolved
src/current/_includes/v25.3/userfile-examples/freetier-userfile-note.md
Outdated
Show resolved
Hide resolved
src/current/_includes/v25.4/userfile-examples/freetier-userfile-note.md
Outdated
Show resolved
Hide resolved
|
||
{{site.data.alerts.callout_info}} | ||
To orchestrate a physically distributed cluster in production, see [Orchestrated Deployments]({% link {{ page.version.version }}/cockroachdb-operator-overview.md %}). To deploy a 30-day free CockroachDB {{ site.data.products.dedicated }} cluster instead of running CockroachDB yourself, see the [Quickstart]({% link cockroachcloud/quickstart.md %}). | ||
To orchestrate a physically distributed cluster in production, see [Orchestrated Deployments]({% link {{ page.version.version }}/cockroachdb-operator-overview.md %}). To deploy a 30-day free CockroachDB {{ site.data.products.advanced }} cluster instead of running CockroachDB yourself, see the [Quickstart]({% link cockroachcloud/quickstart.md %}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta: this "30-day free" may be wrong now (all free trial info appears to be here and refers to cloud credits), feel like we as a team need to have the DRY conversation in a more structured way.
idk if you feel like replacing these uses of "30-day free" in this PR to say "free trial" or if that should be another PR, let me know and i'll file an issue if the latter. Probably the latter is The Right Thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that this is probably legacy language, but having already dealt with some of these politics I definitely want to run by PM before changing any free trial language
f421a47
to
6454a0f
Compare
https://cockroachlabs.atlassian.net/browse/DOC-14812
Addressing instances in these pages and elsewhere deemed appropriate.