Skip to content

Conversation

JonasScholl
Copy link
Member

We actually don't have to implement anything on our own for SSL support, however I added the option to pass keyword arguments to the DB Engine in the DatabaseSetup constructor (which is a good idea anyways I guess). With psycopg2, you can also just require SSL via query parameter in the DB URI, but specifying it in the engine config is also valid.

Changelog:

  • enable passing DB engine config in DatabaseSetup constructor
  • add integration tests with SSL enabled

I had to do a bit of refactoring of the integration tests since adding table classes multiple times messed up the table medatata, but nothing big

resolves #7

@JonasScholl
Copy link
Member Author

JonasScholl commented Apr 8, 2023

hmm, seems like the new docker-compose db setup doesn't work in the pipeline for some reason... works on my machine though 😂 will look into it

Copy link
Contributor

@yannicschroeer yannicschroeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside the tests 😄

@yannicschroeer
Copy link
Contributor

yannicschroeer commented Apr 8, 2023

I fixed your tests. The actual issue was: private key file "/var/lib/postgresql/server.key" must be owned by the database user or root I found a github issues that stated that the image already comes with certificates. I used them instead to fix it with the least effort.

3.9 Tests fail because of some typing stuff I think.

@JonasScholl JonasScholl enabled auto-merge (squash) April 9, 2023 07:48
@JonasScholl JonasScholl merged commit cae608c into main Apr 9, 2023
@JonasScholl JonasScholl deleted the ssl-support branch April 9, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSL Support

2 participants