-
-
Notifications
You must be signed in to change notification settings - Fork 5
New Beginner and Advanced Practice and Solutions #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There seems to be an error in merging to the master branch. My forked repo: https://github.com/ArmeetJatyani/java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the practice problems Armeet! I left comments and suggestions on some files, if you could take a look that'd be great.
src/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java
Outdated
Show resolved
Hide resolved
src/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java
Outdated
Show resolved
Hide resolved
src/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java
Outdated
Show resolved
Hide resolved
src/com/codefortomorrow/beginner/chapter2/practice/VariableTypes.java
Outdated
Show resolved
Hide resolved
src/com/codefortomorrow/beginner/chapter2/solutions/ApplesOranges.java
Outdated
Show resolved
Hide resolved
src/com/codefortomorrow/beginner/chapter2/solutions/ApplesOranges.java
Outdated
Show resolved
Hide resolved
src/com/codefortomorrow/beginner/chapter2/solutions/VariableTypes.java
Outdated
Show resolved
Hide resolved
…t.java Co-authored-by: Rebecca Dang <[email protected]>
…t.java Co-authored-by: Rebecca Dang <[email protected]>
…es.java Co-authored-by: Rebecca Dang <[email protected]>
…ges.java Co-authored-by: Rebecca Dang <[email protected]>
…ges.java Co-authored-by: Rebecca Dang <[email protected]>
…pes.java Co-authored-by: Rebecca Dang <[email protected]>
…t.java Co-authored-by: Rebecca Dang <[email protected]>
…t.java Co-authored-by: Rebecca Dang <[email protected]>
…t.java Co-authored-by: Rebecca Dang <[email protected]>
….java Co-authored-by: Rebecca Dang <[email protected]>
…t.java Co-authored-by: Rebecca Dang <[email protected]>
…t.java Co-authored-by: Rebecca Dang <[email protected]>
@phrdang all requested changes have been addressed, and the latest version has been pushed |
…java Co-authored-by: Rebecca Dang <[email protected]>
…es.java Co-authored-by: Rebecca Dang <[email protected]>
…es.java Co-authored-by: Rebecca Dang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, changes made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just had one more question (see the LinkedList.java
solution).
src/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phrdang I don't see any comments anywhere. Is it ready for approval?
Whoops I think it was accidentally resolved. Here's a screenshot: |
Alright, I'm on it! |
src/com/codefortomorrow/beginner/chapter2/solutions/VariableTypes.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed UUID usage, and removed "bad practices."
src/com/codefortomorrow/beginner/chapter1/solutions/HelloWorld.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments but they were really small things. Just fix those and you should be good to go :)
….java Co-authored-by: JJ27 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your submissions! Looks good to me :)
Also @ArmeetJatyani I wanted to note that these changes will be implemented in the curriculum during the summer session since we're currently in the process of transferring our curriculum from Thinkific to another platform. I will merge your PR now though. |
Thanks! Sounds great! |
Update: Added stuff to Notion (the actual curriculum)
TODO
|
Changes
I realized the lack of enough practice problems in certain chapters, so I created numerous comprehensive practice problems with respective solutions.
Beginner
Chapter 1 Changes
Chapter 2 Changes
Chapter 4 Changes
Advanced
Chapter 16 Changes
TODO: