Skip to content

New Beginner and Advanced Practice and Solutions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Mar 23, 2021

Conversation

armeetj
Copy link
Contributor

@armeetj armeetj commented Mar 15, 2021

Changes

I realized the lack of enough practice problems in certain chapters, so I created numerous comprehensive practice problems with respective solutions.

Beginner

Chapter 1 Changes

  • new HelloWorld practice and solution: practice std output
  • new Comments practice and solution: practice writing single and multi-line comments

Chapter 2 Changes

  • new ApplesOranges practice and solution: learn to concatenate and process Strings/variables
  • new VariableTypes practice and solution: learn to define variables of different datatypes

Chapter 4 Changes

  • new CarDealership practice and solution: learn to use expressions to store values in variables

Advanced

Chapter 16 Changes

  • new LinkedList practice and solution: learn to use multiple classes and OOP to implement a Linked List

TODO:

  • advanced: add new exercises for Stack, Queue, Bag implementations
  • beginners: possibly more exercises with String formatting

@armeetj
Copy link
Contributor Author

armeetj commented Mar 15, 2021

There seems to be an error in merging to the master branch.
Could someone please look into this?

My forked repo: https://github.com/ArmeetJatyani/java

Copy link
Member

@phrdang phrdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the practice problems Armeet! I left comments and suggestions on some files, if you could take a look that'd be great.

armeetj and others added 14 commits March 15, 2021 17:14
@armeetj
Copy link
Contributor Author

armeetj commented Mar 16, 2021

@phrdang all requested changes have been addressed, and the latest version has been pushed

Copy link
Contributor Author

@armeetj armeetj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, changes made.

@armeetj armeetj requested a review from phrdang March 16, 2021 07:51
Copy link
Member

@phrdang phrdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had one more question (see the LinkedList.java solution).

Copy link
Contributor Author

@armeetj armeetj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phrdang I don't see any comments anywhere. Is it ready for approval?

@phrdang
Copy link
Member

phrdang commented Mar 17, 2021

@phrdang I don't see any comments anywhere. Is it ready for approval?

Whoops I think it was accidentally resolved. Here's a screenshot:

Screen Shot 2021-03-17 at 11 22 02 AM

@armeetj
Copy link
Contributor Author

armeetj commented Mar 19, 2021

@phrdang I don't see any comments anywhere. Is it ready for approval?

Whoops I think it was accidentally resolved. Here's a screenshot:

Screen Shot 2021-03-17 at 11 22 02 AM

Alright, I'm on it!

@armeetj armeetj requested a review from phrdang March 22, 2021 18:10
Copy link
Contributor Author

@armeetj armeetj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed UUID usage, and removed "bad practices."

Copy link
Contributor

@JJ27 JJ27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments but they were really small things. Just fix those and you should be good to go :)

Copy link
Member

@phrdang phrdang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your submissions! Looks good to me :)

@phrdang
Copy link
Member

phrdang commented Mar 23, 2021

Also @ArmeetJatyani I wanted to note that these changes will be implemented in the curriculum during the summer session since we're currently in the process of transferring our curriculum from Thinkific to another platform. I will merge your PR now though.

@phrdang phrdang merged commit 1a9bd2f into code4tomorrow:master Mar 23, 2021
@armeetj
Copy link
Contributor Author

armeetj commented Mar 26, 2021

Thanks! Sounds great!

@phrdang
Copy link
Member

phrdang commented Jul 7, 2021

Update: Added stuff to Notion (the actual curriculum)

  • Ch. 1.1: HelloWorld, Comments
  • Ch. 2.1: ApplesOranges, VariableTypes (see Fix VariableTypes solution errors #27 )
  • Ch. 4.5: CarDealership (it was already on Notion, but I just updated the instructions)

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants