Skip to content

Conversation

renatoarg
Copy link
Contributor

@renatoarg renatoarg commented Mar 6, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Check if the completion "isLoading" before update UI with "Typing..." animation.

💡 Motivation and Context

UI bug -> https://ymedialabs.atlassian.net/browse/CM-1216

💚 How did you test it?

There are no steps to reproduce this issue. It happens randomly. The best way to try to reproduce it making multiple completion requests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

🔮 Next steps

📸 Screenshots / GIFs

@renatoarg renatoarg requested review from kikoso and osugikoji March 6, 2023 14:41
@renatoarg renatoarg self-assigned this Mar 6, 2023
@kikoso
Copy link
Contributor

kikoso commented Mar 6, 2023

Looks good!

@renatoarg renatoarg merged commit 91a1cea into main Mar 6, 2023
@kikoso kikoso deleted the jira/CM-1216/android-typing-bug branch June 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants