[Android] CM-1120 - Android UI fixes #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can disable the input field and send button while the message is loading, to ensure only one message can be sent at a time. What do you think? |
Good point, I am working on that. Thanks! |
kikoso
reviewed
Feb 1, 2023
android-sample/src/main/java/co/yml/ychatgpt/android/MainActivity.kt
Outdated
Show resolved
Hide resolved
kikoso
reviewed
Feb 1, 2023
android-sample/src/main/java/co/yml/ychatgpt/android/ui/ChatLayout.kt
Outdated
Show resolved
Hide resolved
kikoso
reviewed
Feb 1, 2023
|
Left a couple of very minor comments @renatoarg, looking great! |
Great comments @kikoso. I am working on them. |
Add ViewModel, di, project structure
renatoarg
force-pushed
the
jira/CM-1120/android-ui-fixes
branch
from
05d102d to
f66d630
Compare
osugikoji
reviewed
Feb 7, 2023
android-sample/src/main/java/co/yml/ychatgpt/android/ui/MainScreen.kt
Outdated
Show resolved
Hide resolved
android-sample/src/main/java/co/yml/ychatgpt/android/ui/MainScreen.kt
Outdated
Show resolved
Hide resolved
osugikoji
approved these changes
Feb 8, 2023
kikoso
approved these changes
Feb 9, 2023
|
Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CM-1120
Android UI fixes
Add "typing" as loading state for server requests
Add "Enter any message and chat GPT will answer it" layout when there are no messages in the chat
Add automatic scroll when new messages are added to the chat
Screen.Recording.2023-01-30.at.11.45.56.mov