Skip to content

feature: create audio translations entrypoint #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2023
Merged

feature: create audio translations entrypoint #60

merged 4 commits into from
Apr 6, 2023

Conversation

osugikoji
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Creates audio translations entrypoint based on the following ticket: https://ymedialabs.atlassian.net/browse/CM-1319

  • Integrates audio translations API
  • Adds sample to showcase on JVM
  • Adds new unit tests

💚 How did you test it?

Tested on platforms samples

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • All linters passing
  • There are no code climate issues

🔮 Next steps

Create android and iOS samples to showcase how it works.

@osugikoji osugikoji requested a review from xyzwilliamxyz April 4, 2023 23:53
@osugikoji osugikoji requested a review from kikoso as a code owner April 4, 2023 23:53
@osugikoji osugikoji merged commit 6e32516 into main Apr 6, 2023
@osugikoji osugikoji deleted the feature/CM-1319/audio-translations branch April 6, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyzwilliamxyz xyzwilliamxyz Awaiting requested review from xyzwilliamxyz

1 more reviewer

@kikoso kikoso kikoso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osugikoji @kikoso