Add files via upload #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retarcorp
approved these changes
May 15, 2020
| if(!file) { | ||
| const pole = document.getElementById('read'); | ||
| const pole1 = document.getElementById('error'); | ||
| pole.setAttribute("style", "background-color: coral"); |
There was a problem hiding this comment.
Делайте стилизацию при помощи классов
| div.innerText = `Length: ${result.length}; Words: ${result.split(' ').length}`; | ||
| const div1 = document.getElementById('results2'); | ||
| div1.innerText = ''; | ||
| var allowed = /\w/i; |
There was a problem hiding this comment.
Должны быть подсчитаны все символы, без исключений
| const result = reader.result; | ||
| const div = document.getElementById('results'); | ||
| div.innerText = `Length: ${result.length}; Words: ${result.split(' ').length}`; | ||
| const div1 = document.getElementById('results2'); |
There was a problem hiding this comment.
Давайте переменным осмысленные названия
| let trs = document.querySelectorAll('#results2 div'); | ||
| let table = document.getElementById('results2'); | ||
| let sorted = [...trs].sort(function(a, b) { | ||
| if (a.children[3].innerHTML >= b.children[3].innerHTML) { |
There was a problem hiding this comment.
Не делайте так сортировку. Это очень трудоемкий для браузера способ. Данные из интерфейса никогда не должны использоваться для сортировки!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.