removed code that causes qr codes to generate incorrectly on linux an… #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes #210 |
Berezhnyk
approved these changes
Nov 11, 2020
Berezhnyk
approved these changes
Nov 11, 2020
codebude
approved these changes
Nov 16, 2020
This was referenced Nov 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue that prevented QR codes with logos to generate correctly on Linux or Mac.
This PR fixes/implements the following bugs/features:
What existing problem does the pull request solve?
QR codes with logos are not generating correctly on Linux or Mac.
Test plan
See comment: #232 (comment)
Closing issues
Fixes #232