Skip to content

Updated Formatter #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Updated Formatter #7

wants to merge 3 commits into from

Conversation

shetty-tejas
Copy link

@shetty-tejas shetty-tejas commented May 13, 2023

I was making a Github Actions project for working with SimpleCov. Turns out this being the recommended gem by SimpleCov, didn't have some functionalities I was thinking of adding support for. So added it here in this PR. If you have any thoughts or suggestions do let me know 😄

What's Changed:

  • Minimum Coverage Check for file. If fails, the file name and the percent_covered is collected in errors.
  • Groups now contain more information such as covered_lines, missed_lines and total_lines.
  • Also returns config details like minimum_coverage and minimum_coverage_by_file.
  • Total metrics as default (even when groups are not available).

@shetty-tejas shetty-tejas changed the title Updated formatter Updated Formatter May 13, 2023
@shetty-tejas shetty-tejas marked this pull request as draft May 13, 2023 20:39
@shetty-tejas shetty-tejas marked this pull request as ready for review May 13, 2023 20:51
Copy link
Contributor

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rslhdyt
Copy link

rslhdyt commented Oct 24, 2023

This is what I need 🚀

@eggplants
Copy link
Contributor

@fede-moya Please review this 🙏

@pboling
Copy link
Contributor

pboling commented Mar 8, 2024

It seems like this organization needs more maintainers!

@f-moya
Copy link
Collaborator

f-moya commented Mar 8, 2024

Hey folks!, I'm sorry. I'll try to review this one over the weekend.

@shetty-tejas
Copy link
Author

@fede-moya were you able to review this?

@shetty-tejas
Copy link
Author

@fede-moya

image

@f-moya
Copy link
Collaborator

f-moya commented Jun 30, 2024

Hey, sorry, I'm a little busy at the moment I'll get here ASAP thanks for the reminder @shettytejas

@eggplants
Copy link
Contributor

It would be great if a new release could be created after these changes are merged.

@shetty-tejas
Copy link
Author

@fede-moya. Any updates with this one?

@shetty-tejas
Copy link
Author

@fede-moya Were you able to check this PR?

@jagthedrummer
Copy link

This looks like it would be super useful, would love to see it get merged and released.

@shetty-tejas
Copy link
Author

@f-moya Any updates on this one?

@shetty-tejas shetty-tejas closed this by deleting the head repository Feb 15, 2025
@pboling pboling mentioned this pull request Feb 15, 2025
@shetty-tejas
Copy link
Author

By mistake, I deleted my fork causing this PR to be closed. I'll get this reopened in a week 🤦🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants