Skip to content

Add Makefile #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2015
Merged

Add Makefile #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9729601
Add Makefile
wfleming Dec 17, 2015
8b66646
rm deprecated bin/test
wfleming Dec 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.PHONY: image test

IMAGE_NAME ?= codeclimate/codeclimate-duplication

image:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I want to keep this task name: as we work with more open source tools as "first party" engines, it'll become more likely those other projects will already have makefiles, so I think "image" might be too generic. I'm wondering if we should standardize on something more explicit that we can expect to use without issue everywhere. Maybe "codeclimate_engine"? Thoughts on this @pbrisbin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. It's worth questioning, but I'm not sure I share your concern:

  • An existing project with an existing Makefile is unlikely to be using image, IMHO. While it is generic, I've never seen make image in the wild
  • The intent of this target is (to me) not specifically to "make a codeclimate engine", but to build a docker image named IMAGE_NAME -- make image seems very apt

For those reasons, I'd be OK going with this for now. Could be worth sleeping on it though.

docker build --rm -t $(IMAGE_NAME) .

test: image
docker run --rm $(IMAGE_NAME) bundle exec rake
5 changes: 0 additions & 5 deletions bin/test
View file
Open in desktop

This file was deleted.