Skip to content

Conversation

adams85
Copy link
Collaborator

@adams85 adams85 commented Nov 8, 2024

Pull Request

Description:
There has been a development at ConfigCat that aims to consolidate the various JS SDKs. In practice, this means that the Node, JS, JS SSR and Chrome Extension SDKs have been merged into a single NPM package (more on the reason for this and the benefits here).

This new SDK is pretty much complete now, the old one is going to be phased out eventually. So this PR makes changes to base the Vue SDK on the new @configcat/sdk package insteadofconfigcat-common`.

Changes:

  • Drop the dependency configcat-common in favor of @configcat/sdk.
  • Refactor the code base to make it work with @configcat/sdk.

Testing:

  • Ran the automated tests.
  • Built the project and tested it with the sample app.

Related Issues:
n/a

@codedbychavez codedbychavez self-requested a review November 14, 2024 16:43
@adams85 adams85 marked this pull request as draft November 20, 2024 15:55
@adams85
Copy link
Collaborator Author

adams85 commented Nov 20, 2024

FYI, I converted this to draft because a newer version of @configcat/sdk is going to be released soon. Then this PR will need to be updated, so no point in reviewing it at the moment.

@adams85 adams85 force-pushed the switch-to-unified-sdk branch from d6aa251 to 70068a1 Compare November 22, 2024 00:55
@adams85 adams85 marked this pull request as ready for review November 22, 2024 00:58
@adams85
Copy link
Collaborator Author

adams85 commented Nov 22, 2024

The new version of @configcat/sdk is out, so I updated the PR. Now it's ready for review.

Copy link
Owner

@codedbychavez codedbychavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @adams85. Works as expected 💯

@codedbychavez codedbychavez merged commit 7db1ee5 into main Dec 3, 2024
2 checks passed
@codedbychavez codedbychavez deleted the switch-to-unified-sdk branch December 3, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants