Skip to content

#13 safari conns #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

chr1sto14
Copy link
Contributor

Address #13 by disabling compression as mentioned in coder/websocket#218

  • test on iOS safari
  • test on desktop safari

@bhelx
Copy link
Member

bhelx commented Jul 4, 2023

Works on desktop safari and mobile emulator, but sometimes the initial connection or the reload of the pages fails:

2023/07/04 17:17:19 INFO: websocket subscriber disconnected: context canceled
Screenshot 2023-07-04 at 12 19 08 PM

@bhelx
Copy link
Member

bhelx commented Feb 15, 2025

We've moved to SSE in #32 so this is out of date. Closing since it's stale. Thanks for offering up a fix though!

@bhelx bhelx closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants