Skip to content

Fix - Workflows native UI via internal router #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/gitops-runtime/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ annotations:
description: Update argo-cd chart to 5.51.6-8-cap-2.9-2024.1.24-ccd7124b3. Includes: window rate limiter for the event reporter; support of apps in non-contoller namespaces for non-GRPC reporting mode; critical vuln fixes for argocd;
- kind: changed
description: Update argo-rollouts chart to 2.32.5-3-analysis-fix
- kind: fixed
description: fix routing to workflows native UI
dependencies:
- name: argo-cd
repository: https://codefresh-io.github.io/argo-helm
Expand Down
1 change: 1 addition & 0 deletions charts/gitops-runtime/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ sealed-secrets:
| argo-workflows.crds.install | bool | `true` | Install and upgrade CRDs |
| argo-workflows.enabled | bool | `true` | |
| argo-workflows.fullnameOverride | string | `"argo"` | |
| argo-workflows.server.baseHref | string | `"/workflows/"` | Do not change. Workflows UI is only accessed through internal router, changing this values will break routing to workflows native UI from Codefresh. |
| argo-workflows.server.extraArgs | list | `["--auth-mode=client"]` | auth-mode needs to be set to client to be able to see workflow logs from Codefresh UI |
| event-reporters.events.argoCDServerServiceName | string | `nil` | LEAVE EMPTY and let the chart logic determine the name. Change only if you are totally sure you need to override ArgoCD service name. |
| event-reporters.events.argoCDServerServicePort | string | `nil` | LEAVE EMPTY and let the chart logic determine the name. Change only if you are totally sure you need to override ArgoCD service port. |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ data:
listen [::]:8080 default_server;
access_log /dev/stdout main;
error_log /dev/stdout;
port_in_redirect off;

{{- if .Values.resolver }}
resolver {{ .Values.resolver }} valid=10s;
Expand All @@ -33,6 +34,7 @@ data:
proxy_set_header Connection '';
proxy_http_version 1.1;
chunked_transfer_encoding off;
rewrite /workflows(/|$)(.*) /$2 break;

proxy_pass {{ .Values.routing.workflows.internalUrl }};
}
Expand Down
2 changes: 2 additions & 0 deletions charts/gitops-runtime/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ argo-workflows:
# -- auth-mode needs to be set to client to be able to see workflow logs from Codefresh UI
extraArgs:
- --auth-mode=client
# -- Do not change. Workflows UI is only accessed through internal router, changing this values will break routing to workflows native UI from Codefresh.
baseHref: /workflows/
crds:
# -- Install and upgrade CRDs
install: true
Expand Down