added default value and description for ingress skipValidation
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
requested review from
danielm-codefresh,
yaroslav-codefresh,
denis-codefresh,
pasha-codefresh and
a team
as code owners
danielm-codefresh
approved these changes
Aug 18, 2024
|
/e2e |
ATGardner
force-pushed
the
feat/cr-24945-skip-ingress-validation
branch
from
777d867 to
c5c413a
Compare
ATGardner
changed the title
switchValidationskipValidation
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
added default value of false
Why
this value is already being used in pre-install hook. if set - will not attempt to make a web request to ingress host
Notes