Release 0.2.14 #61
Release 0.2.14 #61
Conversation
Co-authored-by: ilia-medvedev-codefresh <[email protected]>
|
/e2e |
| protocol: TCP | ||
| readinessProbe: | ||
| initialDelaySeconds: 10 | ||
| timeoutSeconds: 10 | ||
| httpGet: | ||
| port: 80 | ||
| port: http |
There was a problem hiding this comment.
I think this and the livenessProbe should also be 8080 now.
Also, why are you changing this only for the internal-router?
There was a problem hiding this comment.
There was a problem hiding this comment.
Liveness probe works by port name. If you look at the definition of the port here, you see the port is 8080 but the name is http https://github.com/codefresh-io/gitops-runtime-helm/blob/b0198ee8402129041703e08c0de53eb5f891db7f/charts/gitops-runtime/templates/_components/internal-router/_deployment.yaml#L40C18-L40C18. We are changing it for internal-router because we are switching to unprivileged Nginx to be able to run on rootless (and Openshift). The rest of the components already run rootless
There was a problem hiding this comment.
Oh by bad, I didn't notice that. Thanks :)
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
1 similar comment
|
/e2e |
Signed-off-by: mikhail-klimko <[email protected]>
|
/e2e |
4 similar comments
|
/e2e |
|
/e2e |
|
/e2e |
|
/e2e |
description: Updated
app-proxyto1.2318.1- kind: changed
description: Update ArgoCD version to v2.7.0-cap-CR-18361-custom-instance-label
- kind: changed
description: Switch internal router to unprivileged (rootless) nginx
- kind: changed
description: Installer image now supports arm64 and amd64 platforms
- kind: added
description: Include enrichment images in the chart with possibility to override through values
- kind: fixed
description: Private registry utility - the utility omitted repositories for images with short names