Skip to content

Fix: Cron Trigger Plan-time Validation; Cron Trigger Updates; Cron Trigger Testing #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 29, 2022

Conversation

korenyoni
Copy link
Contributor

@korenyoni korenyoni commented Dec 29, 2022

What

  • Add Cron Trigger plan-time validation
  • Fix Cron Trigger updating (force replacement of resource on any change, because there is no update verb in the cron trigger API)
  • Improve Cron Trigger Testing
  • Misc: remove use of "Hermes" service name in Provider logs. While accurate in the API docs, this may cause unnecessary confusion to users of the Terraform provider.

Why

  • Updating a Cron Trigger results in duplicates
  • No plan-time validation on Cron Triggers

Notes

@korenyoni korenyoni added the bug Something isn't working label Dec 29, 2022
@korenyoni korenyoni merged commit b75d483 into codefresh-io:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs minor source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron Trigger Duplicated When You Try to Modify it Improve Cron Trigger Validation Error Message
2 participants