Skip to content

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 31, 2023

Needs #8130

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Oct 31, 2023
@kenjis kenjis marked this pull request as draft October 31, 2023 06:04
@kenjis kenjis force-pushed the feat-ArrayHelper-dotKeyExists branch 2 times, most recently from d1930b8 to 7ee981a Compare October 31, 2023 06:34
@kenjis kenjis force-pushed the feat-ArrayHelper-dotKeyExists branch 2 times, most recently from 9101a92 to c107070 Compare November 3, 2023 00:44
@kenjis kenjis marked this pull request as ready for review November 3, 2023 00:45
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice recursive implementation.

@kenjis kenjis force-pushed the feat-ArrayHelper-dotKeyExists branch from 3531245 to dce6576 Compare November 6, 2023 01:13
@kenjis kenjis merged commit e875b05 into codeigniter4:4.5 Nov 6, 2023
@kenjis kenjis deleted the feat-ArrayHelper-dotKeyExists branch November 6, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants