Skip to content

refactor: Validation rule field_exists #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2023
Merged

refactor: Validation rule field_exists #8242

merged 2 commits into from
Nov 28, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 22, 2023 •
edited
Loading

Description
Follow-up #8123

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Nov 22, 2023
@kenjis kenjis mentioned this pull request Nov 22, 2023
Merged
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Nov 26, 2023

Can someone please review this PR?

@kenjis kenjis merged commit 9e8786c into codeigniter4:4.5 Nov 28, 2023
@kenjis kenjis deleted the fix-validation-field_exists branch November 28, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @michalsn