Skip to content

Conversation

neznaika0
Copy link
Contributor

Description
I applied the created command lang:finder and got the result:

$ php spark lang:finder --locale en --dir ./system/ --lang-dir ./system/Language --verbose --show-new

CodeIgniter v4.6.3 Command Line Tool - Server Time: 2025-09-13 12:04:29 UTC+00:00

Directory to scan: /home/neznaika0/www/codeigniter/development/system/
Directory for saving: /home/neznaika0/www/codeigniter/development/system/Language/

File found: API/ResponseTrait.php
...
File found: util_bootstrap.php

+----------+---------------------------------------+
| File     | Key                                   |
+----------+---------------------------------------+
| Honeypot | Honeypot.noHiddenValue                |
| Honeypot | Honeypot.noNameField                  |
| Honeypot | Honeypot.noTemplate                   |
| Honeypot | Honeypot.theClientIsABot              |
| Router   | Router.invalidParameterType           |
| Security | Security.invalidSameSiteSetting...{0} |
| Time     | Time.invalidHour...{0}                |
| images   | images.webpNotSupported               |
+----------+---------------------------------------+

Files found: 579
New translates found: 8
Bad translates found: 0
All operations done!

It's nice that the command is working 😄
This PR adds new keys. Added a missing key Security.invalidSameSiteSetting for compatibility.
Please check the quality of the translation.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
Copy link
Member

Do you mean to say those have lang() calls but there's actually no language files for them? How can that be missed! 🤔

@neznaika0
Copy link
Contributor Author

Do you mean to say those have lang() calls but there's actually no language files for them? How can that be missed! 🤔

See #1063 In ancient times, there was no approval.
Empty translations don't cause errors, so no one is interested in searching.

For 4.7, you can clean up all deprecations. Including removing exceptions

@neznaika0
Copy link
Contributor Author

Removed forNoHiddenValue() and lang key
Change to invalidHours
Changed invalidParameterType to invalidParameter

@michalsn
Copy link
Member

Instead of removing forNoHiddenValue(), please deprecate it.

Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

@michalsn michalsn merged commit 6e98ce5 into codeigniter4:develop Sep 14, 2025
48 of 49 checks passed
@michalsn
Copy link
Member

Thank you @neznaika0

@neznaika0 neznaika0 deleted the fix/add-lang-keys branch September 14, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants