This repository was archived by the owner on Apr 13, 2025. It is now read-only.
nodecg-io-googleapis - closes #226 #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should, as the merge commit will by default contain the PR title in the commit message so it will also contain the close note, which will therefore close the issue. The better solution is still to just write it in the PR description which triggers githubs feature that links the issue and PR. |
hlxid
reviewed
Oct 9, 2021
|
Yeah, I was working on updating the available samples and fixing some issues (2 of your mentions). But didn't have the time to finish and commit it yet |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.