Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

fix: replace express.Router references with nodecg.Router #423

Merged
merged 1 commit into from
Jan 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions services/nodecg-io-googleapis/extension/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Result, emptySuccess, success, error, ServiceBundle, Logger } from "nod
import { google, GoogleApis } from "googleapis";
import type { Credentials } from "google-auth-library/build/src/auth/credentials";
import type { OAuth2Client } from "google-auth-library/build/src/auth/oauth2client";
import * as express from "express";
import opn = require("open");

interface GoogleApisServiceConfig {
Expand Down Expand Up @@ -49,7 +48,7 @@ class GoogleApisService extends ServiceBundle<GoogleApisServiceConfig, GoogleApi
});

return new Promise((resolve, reject) => {
const router = express.Router();
const router = this.nodecg.Router();

router.get("/nodecg-io-googleapis/oauth2callback", async (req, res) => {
try {
Expand Down
1 change: 0 additions & 1 deletion services/nodecg-io-googleapis/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
},
"dependencies": {
"@types/gapi": "^0.0.41",
"express": "^4.17.2",
"googleapis": "^92.0.0",
"nodecg-io-core": "^0.3.0",
"open": "^8.4.0"
Expand Down
4 changes: 1 addition & 3 deletions services/nodecg-io-spotify/extension/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { NodeCG } from "nodecg-types/types/server";
import { Result, emptySuccess, success, error, ServiceBundle, Logger } from "nodecg-io-core";
import * as express from "express";
import { Router } from "express";
import SpotifyWebApi = require("spotify-web-api-node");
import open = require("open");

Expand Down Expand Up @@ -77,7 +75,7 @@ class SpotifyService extends ServiceBundle<SpotifyServiceConfig, SpotifyServiceC

private mountCallBackURL(spotifyApi: SpotifyWebApi, logger: Logger) {
return new Promise((resolve) => {
const router: Router = express.Router();
const router = this.nodecg.Router();

router.get(callbackEndpoint, (req, res) => {
// Get auth code with is returned as url query parameter if everything was successful
Expand Down
1 change: 0 additions & 1 deletion services/nodecg-io-spotify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
},
"dependencies": {
"@types/spotify-web-api-node": "^5.0.3",
"express": "^4.17.2",
"nodecg-io-core": "^0.3.0",
"open": "^8.4.0",
"spotify-web-api-node": "^5.0.2"
Expand Down