Browser back button weird behaviour

[avelino]

• code-server version: master branch
• OS Version: macOS

Description

I use Magic Trackpad 2 to move mouse point and swipe to right returning to previous page

Steps to Reproduce

1. open new tab
2. open code-server in new tab

[tiffany352]

I have a mouse that has hardware forward/back buttons and I have muscle memory for using them to switch between files in VS code. It would be great if code-server could map those bindings, as well!

[kylecarbs]

Should prompt now 🎊

[CSchlipp]

I'd like to reopen this issue.
The latest version shows exactly the same behavior as described in this bug report.
Mouse-Back button navigates to a previous browser page in Chrome. The browser only prompts for confirmation if there are unsaved changes in the currently opened file. Unsaved changes in other editor tabs do not open a prompt.

Ideally, the back button should have the same function as in VS Code, namely to navigate to the previous file within this codespace workspace.

Versions:
Version: 1.43.2
Commit: 28e91ba
Date: 2020-04-14T22:51:57.043Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36

[mahmoudajawad]

I can confirm that back button does navigate to previous page without any warning.

personally I believe navigation buttons should not interfere with code-server functionalities, that is not having any effect on code-server, either by triggering browser history functionality nor editor previous file functionality.

[CSchlipp]

@kylecarbs Would you be so kind to please reopen this issue?

[code-asher]

At some point I stopped getting prompts as well. My changes are still there though when I come back to the editor. I wonder if VS Code opted to start doing that instead of the prompt.

When I use code-server as a PWA sometimes back/forward switches between files (as they should) and sometimes they cause page navigation. It's a bit strange and probably worth investigating.

[avelino]

When:

• I open a blank page (new browser tab)
• I type the address of the http server (ex: 127.0.0.1:5050) that runs my code-server

the browser enables the "back button" to return to the blank page

[nhooyr]

We should figure out the exact behaviour and document it as an FAQ entry.

[nhooyr]

Can reproduce though, I randomly get the prompts as well on Chrome.

In Safari however I get them 100% of the time lol.

[nhooyr]

Looks like the pattern is if you just edit the file and leave, no prompt but if you save the file explicitly once, then it prompts you.

[nhooyr]

Nvm, just seems completely random lol.