install-extension vadimcn.vscode-lldb: wrong platform aarch64 expecting x86-64

[steverweber]

• Local OS: ubuntu20.04
• Remote OS: ubuntu20.04
• Remote Architecture: x86_64
• code-server --version: 3.8.0 c4610f7

REF: vadimcn/codelldb#402

on a fresh install with cache dir's cleared:

code-server -vvv --install-extension vadimcn.vscode-lldb

installs extension but for the wrong platform (ARM aarch64 when expecting x86_64)

s8weber@jupyter-p03:~/.local/share/code-server/extensions/vadimcn.vscode-lldb-1.6.0/adapter$ file ./codelldb
./codelldb: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, BuildID[sha1]=89f52b409d1971f91b4192d84e1b624aa4e942ab, not stripped

Logs show:

[2020-12-22 15:07:24.745] [cli] [trace] Started scanning user extensions
[2020-12-22 15:07:24.745] [cli] [trace] Scanned user extensions: 0
[2020-12-22 15:07:24.745] [cli] [trace] Extension VSIX downlads cache dir does not exist
[2020-12-22 15:07:24.748] [cli] [trace] RequestService#request https://extensions.coder.com/api/extensionquery
[2020-12-22 15:07:24.836] [cli] [trace] RequestService#request https://storage.googleapis.com/vscode-extension-assets/vscode-extensions/vscode/vadimcn/vscode-lldb/1.6.0/Microsoft.VisualStudio.Code.Manifest
[2020-12-22 15:07:24.883] [cli] [trace] ExtensionManagementService.refreshReportedCache
[2020-12-22 15:07:24.883] [cli] [trace] ExtensionManagementService.refreshReportedCache - got 0 reported extensions from service
[2020-12-22 15:07:24.884] [cli] [info] Installing extension: vadimcn.vscode-lldb
[2020-12-22 15:07:24.884] [cli] [trace] Started scanning user extensions
[2020-12-22 15:07:24.884] [cli] [trace] Scanned user extensions: 0
[2020-12-22 15:07:24.884] [cli] [trace] Started downloading extension: vadimcn.vscode-lldb
[2020-12-22 15:07:24.885] [cli] [trace] ExtensionGalleryService#download vadimcn.vscode-lldb
[2020-12-22 15:07:24.885] [cli] [trace] RequestService#request https://storage.googleapis.com/vscode-extension-assets/vscode-extensions/vscode/vadimcn/vscode-lldb/1.6.0/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&install=true
[2020-12-22 15:07:26.636] [cli] [info] Downloaded extension: vadimcn.vscode-lldb undefined
[2020-12-22 15:07:26.779] [cli] [trace] Started extracting the extension from /home/s8weber/.local/share/code-server/CachedExtensionVSIXs/vadimcn.vscode-lldb-1.6.0 to /home/s8weber/.local/share/code-server/extensions/.vadimcn.vscode-lldb-1.6.0
[2020-12-22 15:07:27.067] [cli] [info] Extracted extension to /home/s8weber/.local/share/code-server/extensions/.vadimcn.vscode-lldb-1.6.0: vadimcn.vscode-lldb
[2020-12-22 15:07:27.067] [cli] [info] Renamed to /home/s8weber/.local/share/code-server/extensions/vadimcn.vscode-lldb-1.6.0
[2020-12-22 15:07:27.070] [cli] [info] Installation completed. vadimcn.vscode-lldb
[2020-12-22 15:07:27.072] [cli] [info] Extensions installed successfully: vadimcn.vscode-lldb

When manually downloading https://storage.googleapis.com/vscode-extension-assets/vscode-extensions/vscode/vadimcn/vscode-lldb/1.6.0/Microsoft.VisualStudio.Services.VSIXPackage?redirect=true&install=true I find that the package is for ARM.

I'm not sure if this is a bug in the extension manifest or platform detection that might be passed through a web request.

[steverweber]

note:
https://storage.googleapis.com/vscode-extension-assets/vscode-extensions/vscode/vadimcn/vscode-lldb/1.6.0/Microsoft.VisualStudio.Code.Manifest

has a config > platformPackages section that seems to be ignored.. /perhaps that's normal/

config
platformPackages |  
url | "https://github.com/vadimcn/vscode-lldb/releases/download/v${version}/${platformPackage}"
platforms |  
x64-linux | "codelldb-x86_64-linux.vsix"
arm64-linux | "codelldb-aarch64-linux.vsix"
arm-linux | "codelldb-arm-linux.vsix"
x64-darwin | "codelldb-x86_64-darwin.vsix"
x64-win32 | "codelldb-x86_64-windows.vsix"
ia32-win32 | "codelldb-x86_64-windows.vsix"

[vadimcn]

The culprit seems to be the process code-server uses to populate its marketplace. The FAQ says "It works by scraping GitHub for VS Code extensions and building them", however CodeLLDB's build process is rather involved, so I doubt that this works. Instead, it probably falls back to picking .vsix packages from Releases, in which case this all makes sense, because codelldb-aarch64-linux.vsix happens to be the first one.

[oxy]

It is indeed because we are scraping the Releases from GitHub repos - as a stopgap, I think it would be best to download the version that corresponds to your architecture and OS and then install it via code-server --install-extension.

[vadimcn]

I think it would be best to download the version that corresponds to your architecture and OS and then install it via code-server --install-extension.

Sure, but this only works after the user has realized what the problem is.
If you want to make this smooth for your users, you need to arrange that your scraping process picks codelldb-bootstrap.vsix package (which is the one I publish to MS Marketplace). Upon activation, it detects current platform and downloads the appropriate full package.

[ArArgon]

Also, I noticed it also mistook the architecture of cpptools. I had to download the vsix package manually to get it installed. Tbh, I find it a little bit annoying.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.