Lando commands fail silently when run from a code-server terminal

[tanc]

OS/Web Information

• Web Browser: Edge, Safari (iOS)
• Local OS: Windows, iPadOS
• Remote OS: Windows 10
• Remote Architecture: WSL2 running Ubuntu 20.04, ZSH (same issue with Bash)
• code-server --version: 3.9.3 fe2dc2deb08e378069891b622bb62ad1d261d1b1

Problem description

For reasons I don't understand, a single specific terminal command won't run (silently fails) when executed under code-server's terminal. This does not happen in the 'normal' terminal and does not happen in VS Code's terminal. They are all using exactly the same system (confirmed but entering a command in one, then cycling back through the history in another and confirmed the same commands are executed).

Steps to Reproduce

1. Install Lando
2. Run lando version in any terminal (except the terminal of code server) and confirm there is output
3. Open code server and enter lando version in the terminal and confirm there is no output

Expected

Terminal should output:

$ lando version
$ v3.1.2

Actual

There is no output after running the command:

$ lando version

An exit code of 4 is shown if $? is entered afterwards

Logs

I ran:

code-server --log debug
and entered the command in the terminal.

1. The most recent files from ~/.local/share/code-server/coder-logs - **There are two files here (stderr, stdout), both empty.**
2. The browser console. **Attached in logs.zip below**
3. The browser network tab. **Attached in logs.zip below**

logs.zip

Screenshot

lando version in the WSL2 terminal:

lando version in the code-server terminal:

Notes

This issue can be reproduced in VS Code: No, the issue does not happen in VS Code.

[jsjoeio]

Okay here are the steps I took to reproduce using macOS + Chrome:

1. Install Lando v3.1.2 via the dmg file
2. Open Terminal (macOS default)
3. Run lando version

Now, with code-server:

1. Run code-server --auth none (code-server 3.9.3 fe2dc2d)
2. Open localhost:8080/ in Chrome
3. Open Integrated Terminal
4. Run lando version

Actually...none of the Lando commands are working 🤔 That's very strange.

Lando Docs

Looking a bit further into this, I see these two messages:

If you do not run most of these commands in a directory that contains a Landofile you will likely not get the expected result.

Windows users must use a real, non-emulated, TTY
This is an upstream "restriction" imposed on us by NodeJS and python. We recommend using the shell shipped with Git for Windows but only the cmd.exe variant NOT the one powered by minTTY. That said your safest bet is to use cmd.exe or PowerShell. Other shells may work but have not been tested.

If your shell does not work you will likely see an error message like the input device is not a TTY. See nodejs/node#3006

I don't think that's related but adding here just in case.

Source: Lando CLI docs

Hard to tell if this is specific to code-server or Lando. Let's see if @code-asher or @oxy has any input.

[tanc]

@jsjoeio thank you for taking the time to reproduce. It seems strange that Lando commands wouldn’t work in code server but I don’t know enough about the internals to know why.

[jsjoeio]

Thanks for leaving such clear instructions! It is very strange. I would think it would at least log an error or something. I'm really unsure of what could be happening. Hopefully the others have an idea.

[tanc]

I've added a bug report in the Lando repo to cross reference this issue: lando/lando#3000
Also updated the issue title as I think it is specific to Lando.

[oxy]

Thanks for the instructions! I just attempted to reproduce it on my Linux build, and it works perfectly fine on both 3.9.3 and on main (which should be 3.10.0 by Monday). I feel like this might be macOS-specific too.

[tanc]

Thanks for testing! Interesting... I'm doing this in a Linux environment, using WSL2, so I don't think it's MacOS specific. I'll see if I can test (what will be) 3.10.0 version

[oxy]

That's curious - another thing that differed for me was that I was using lando from git instead of the .rpm package because I can't really put docker-ce in the toolbox container I use for dev 🤔

Does using lando from git instead of a release change anything?

[tanc]

Ah yes, running the version from git works!

Steps:

1. git clone https://github.com/lando/lando.git
2. cd lando
3. yarn install
4. Open code server terminal and cd to lando repo
5. cd bin
6. ./lando.js version

./lando.js version
v3.1.2

[oxy]

That's interesting - looking at commit logs nothing really changed after v3.1.2 was released besides some documentation... 🤔

[tanc]

Yes I don't think it's lando code itself... I'm just trying different tags to see if any don't work. I suspect its something about the way its packaged and installed but no idea why that would be an issue at this point.

Confirmed, running off different tags from the source (and doing a yarn install to be sure) doesn't seem to make any difference, the tagged version is correctly displayed in code-server's terminal.

[tanc]

I've updated the issue on the Lando side, lets see what the maintainers think over there. A very curious issue!