Skip to content

refactor: change get_artifacts_url in lib.sh #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 26, 2021

This PR refactors get_artifacts_url in lib.sh to work of the version branch instead of the head sha.

@jsjoeio jsjoeio requested a review from a team as a code owner March 26, 2021 17:07
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

This now looks for the version branch i.e. v3.9.2
to grab the artifacts instead of the head_sha
which was faulty in the past.
@jsjoeio jsjoeio force-pushed the jsjoeio/fix-get-artifact-url branch from a559abc to f27c039 Compare March 26, 2021 17:30
@jsjoeio jsjoeio merged commit be02218 into main Mar 26, 2021
@jsjoeio jsjoeio deleted the jsjoeio/fix-get-artifact-url branch March 26, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants