Skip to content

chore: update eslint-plugin-import to latest #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2023
Merged

chore: update eslint-plugin-import to latest #5936

merged 4 commits into from
Jan 3, 2023

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 3, 2023 •
edited
Loading

@jsjoeio jsjoeio requested a review from a team as a code owner January 3, 2023 16:48
@jsjoeio jsjoeio self-assigned this Jan 3, 2023
@jsjoeio jsjoeio added security Security related dependencies Pull requests that update a dependency file labels Jan 3, 2023
@jsjoeio jsjoeio added this to the January 2022 milestone Jan 3, 2023
@jsjoeio jsjoeio temporarily deployed to npm January 3, 2023 17:09 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 3, 2023 •
edited
Loading

✨ code-server dev build published to npm for PR #5936!

  • Last publish status: success
  • Commit: b4c4e76

To install in a local project, run:

npm install @coder/code-server-pr@5936

To install globally, run:

npm install -g @coder/code-server-pr@5936

@code-asher
Copy link
Member

I think we can update this without a resolution which might be better because if modules update their version of json5 to something greater we will force it back down again with the resolution (this probably applies to most of our resolutions actually now that I think about it).

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 3, 2023

Ah okay, I'll do that instead in this PR.

@jsjoeio jsjoeio enabled auto-merge (squash) January 3, 2023 20:33
@jsjoeio jsjoeio changed the title chore: pin json5 to 1.0.2 chore: update eslint-plugin-import to latest Jan 3, 2023
@jsjoeio jsjoeio temporarily deployed to npm January 3, 2023 20:33 — with GitHub Actions Inactive
@jsjoeio jsjoeio temporarily deployed to npm January 3, 2023 20:37 — with GitHub Actions Inactive
code-asher
code-asher approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jsjoeio jsjoeio merged commit 077a8f6 into main Jan 3, 2023
@jsjoeio jsjoeio deleted the jsjoeio/fix-deps branch January 3, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
dependencies Pull requests that update a dependency file security Security related
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher