Review: Even though we've fixed defers here, there's still `cmd/envbuilder` where e.g. `closeLogs` won't fire since we execve(2) after this. _Originally posted by @mafredri in https://github.com/coder/envbuilder/pull/359#discussion_r1777477126_
Activity
johnstcn commentedon Sep 27, 2024
We could maybe add a
PreExec []func()
field toenvbuilder.Options
that will get called right before weExec
?Edit: it's simpler to just pass them into
Run()
/RunCacheProbe
.fix: add preExec to Run (#368)
johnstcn commentedon Sep 27, 2024
Need to be careful about LogSenderV2 (see #371); will fix this later.
fix: add preExec to Run (#368)