feat: codex qol updates #348
Open
+251
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation script for new options
…ional MCP server settings
…configuration details
…r instruction prompts
…with default configuration details
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Codex module for better usability and configuration management. It simplifies variable names, improves defaults, and consolidates configuration files outside the project directory.
- Replaced granular configuration variables with
base_config_tomlandadditional_mcp_serversfor more flexible configuration - Set secure defaults to enable minimal configuration while supporting advanced customization
- Moved all Codex-related files from the project directory to the
~/.codexdirectory
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| main.tf | Consolidated configuration variables and updated variable descriptions with better defaults |
| scripts/install.sh | Refactored configuration generation logic and moved AGENTS.md to ~/.codex directory |
| scripts/start.sh | Improved logging output formatting and updated comments for clarity |
| main.test.ts | Updated tests to reflect new configuration structure and file locations |
| README.md | Updated documentation to reflect new configuration approach and examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…y were just expressing the defaults
matifali
previously approved these changes
Aug 21, 2025
| } | ||
| ``` | ||
|
|
||
| > [!WARNING] | ||
| > **Security Notice**: This module configures Codex with a `workspace-write` sandbox that allows AI tasks to read/write files in the specified folder. While the sandbox provides security boundaries, Codex can still modify files within the workspace. Use this module in trusted environments and be aware of the security implications. |
There was a problem hiding this comment.
Why this change? We do prefer GFM style alerts.
| @@ -150,6 +140,6 @@ module "codex" { | |||
|
|
|||
| ## References | |||
|
|
|||
| - [OpenAI API Documentation](https://platform.openai.com/docs) | |||
| - [Codex CLI Documentation](https://github.com/openai/codex) | |||
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
matifali
approved these changes
Aug 21, 2025
matifali
reviewed
Aug 21, 2025
| @@ -53,41 +53,21 @@ variable "codex_version" { | |||
| default = "" # empty string means the latest available version | |||
| } | |||
|
|
|||
| variable "extra_codex_settings_toml" { | |||
| variable "base_config_toml" { | |||
There was a problem hiding this comment.
@DevelopmentCats, are these breaking changes? We are changing the input names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Module Information
Path:
registry/coder-labs/modules/codexNew version:
v1.1.0Breaking change: [X] Yes [ ] No
Testing & Validation
bun test)bun run fmt)Related Issues