-
Notifications
You must be signed in to change notification settings - Fork 54
feat: add healthcheck and config options to JupyterLab Module #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds health check functionality and automatic CSP configuration to the JupyterLab module to simplify setup for iframe embedding in Coder workspaces.
- Added automatic Content-Security-Policy fallback configuration when no custom config is provided
- Added health check endpoint monitoring for the JupyterLab service
- Introduced configurable JupyterLab server settings through a new
config
variable
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
registry/coder/modules/jupyterlab/main.tf | Added locals for CSP fallback config, new config variable, config script resource, and healthcheck block |
registry/coder/modules/jupyterlab/main.test.ts | Added test coverage for config file creation and validation of empty config behavior |
registry/coder/modules/jupyterlab/README.md | Updated documentation with configuration examples and CSP requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Description
Simplified JupyterLab module configuration and added automatic CSP headers for iFrame embedding for Coder Tasks. The module now works out of the box without requiring users to manually configure Content-Security-Policy headers.
Changes:
Type of Change
Module Information
Path:
registry/coder/modules/jupyterlab
New version:
v1.2.0
Breaking change: [x] Yes [ ] No
Breaking change: Config behavior changed - now automatically includes CSP when no user config provided
Testing & Validation
bun test
)bun run fmt
)Related Issues
Closes #345