Skip to content

Bug Fix: Not using published views #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bug Fix: Not using published views #4

wants to merge 1 commit into from

Conversation

askdkc
Copy link
Contributor

@askdkc askdkc commented Sep 28, 2022

Even after running php artisan vendor:publish --tag="csv-views", this package is not using that published-view because this helper function is not checking if the published view exists.

Even after running php artisan vendor:publish --tag="csv-views", this package is not using that published-view because this helper function is not checking if the published view exists.
@ousid
Copy link
Member

ousid commented Sep 28, 2022

Thanks, For the PR, @askdkc.

Let me test it once I have time this day, and I'll let you know.

@askdkc
Copy link
Contributor Author

askdkc commented Sep 28, 2022

@ousid there's probably better way to check if the published file path exists. I haven't published any laravel packages before so I'm not sure the way my code checks these file paths are decent or not. If you know better way, please fix the code. Thanks.

@ousid
Copy link
Member

ousid commented Sep 28, 2022

@ousid there's probably better way to check if the published file path exists. I haven't published any laravel packages before so I'm not sure the way my code checks these file paths are decent or not. If you know better way, please fix the code. Thanks.

Yeah, the helper does not interfere with the actual publishable views, I tested before in a fresh Laravel installation, and it works just fine, you may take a look at the demo repository to know more.

Or if you have any issue with the published views, please open an issue instead.

Thanks for the PR @askdkc, but I'm going to close it for now.

@ousid ousid closed this Sep 28, 2022
@askdkc
Copy link
Contributor Author

askdkc commented Sep 28, 2022

Thanks for checking. I think publishing the view usually works fine. I might double check with freshly installed laravel project. BTW, it seems that composer require coderflex/laravel-csv throwing an error now. So I made this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants