Skip to content

using myhtml_tag_id_t in breaking vector instead of unsigned long #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2018
Merged

using myhtml_tag_id_t in breaking vector instead of unsigned long #1

merged 1 commit into from
Nov 25, 2018

Conversation

andreasbaumann
Copy link
Contributor

Fails to build on 32-bit Intel (and ARMv6, ARMv7):

../main.cpp: In lambda function:
../main.cpp:204:43: error: no matching function for call to ‘vec_has(const std::vector<long unsigned int>&, myhtml_tag_id_t&)’
     if(vec_has(breaking, node_iter->tag_id)){ // <br/>
                                           ^
../main.cpp:101:35: note: candidate: ‘template<class T> bool vec_has(const std::vector<T>&, T)’
 template <typename T> inline bool vec_has(const vector<T> &vec, T val){
                                   ^~~~~~~
../main.cpp:101:35: note:   template argument deduction/substitution failed:
../main.cpp:204:43: note:   deduced conflicting types for parameter ‘T’ (‘long unsigned int’ and ‘unsigned int’)
     if(vec_has(breaking, node_iter->tag_id)){ // <br/>
                                           ^
ninja: build stopped: subcommand failed.

@coderobe coderobe merged commit 9f02436 into coderobe:master Nov 25, 2018
@coderobe
Copy link
Owner

Good catch. Thanks!

@andreasbaumann
Copy link
Contributor Author

no problem. :-)

@andreasbaumann andreasbaumann deleted the ia32 branch November 26, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants