Skip to content

.jsx file extension support #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CompuIves opened this issue Jul 13, 2017 · 2 comments
Closed

.jsx file extension support #51

CompuIves opened this issue Jul 13, 2017 · 2 comments

Comments

@CompuIves
Copy link
Member

CompuIves commented Jul 13, 2017

This one should be easy to do, I found out that create-react-app does support the jsx extension. We should update the sandbox to handle these cases.

All the code for this resides in src/sandbox/, if you'd search for js you'll find where we check for the extension.

I believe all logic is in src/sandbox/eval/js/index.js and src/sandbox/utils/resolve-module.js.

@bengummer
Copy link
Contributor

Hey @CompuIves I am keen to have a go at this issue in the next week or so. Been wanting to get to know the codebase so this seems like a good starting point.

P.S. I was initially confused by the issue title, thought it meant JSX support in the editor rather than filenames. Maybe "JSX file extension support"? No big deal either way :)

@CompuIves CompuIves changed the title JSX support .jsx file extension support Jul 13, 2017
@CompuIves
Copy link
Member Author

That's really great @bengummer! I updated the title, don't hesitate to message me if you have any questions 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants