Add .jsx extension support #53
Conversation
| @@ -3,223 +3,225 @@ import { clearCache } from './js'; | |||
|
|
|||
| describe('eval', () => { | |||
There was a problem hiding this comment.
The changes in this file look big, but it's really just indented one level (because of the new forEach loop) and using the loop's jsExtension instead of static .js.
src/sandbox/utils/resolve-module.js
Outdated
| @@ -3,7 +3,7 @@ import type { Module, Directory } from 'common/types'; | |||
|
|
|||
| const compareTitle = (original: string, test: string) => { | |||
| if (original === test) return true; | |||
| if (original === `${test}.js`) return true; | |||
| if (original.match(new RegExp(`^${test}.jsx?$`))) return true; | |||
There was a problem hiding this comment.
Used RegExp here, but happy to switch back to === if you prefer
There was a problem hiding this comment.
Hmm, I'd prefer to let this still be a strict equal, since the case is not very dynamic and building Regexes can be quite expensive.
src/sandbox/utils/resolve-module.js
Outdated
| @@ -3,7 +3,7 @@ import type { Module, Directory } from 'common/types'; | |||
|
|
|||
| const compareTitle = (original: string, test: string) => { | |||
| if (original === test) return true; | |||
| if (original === `${test}.js`) return true; | |||
| if (original.match(new RegExp(`^${test}.jsx?$`))) return true; | |||
There was a problem hiding this comment.
Hmm, I'd prefer to let this still be a strict equal, since the case is not very dynamic and building Regexes can be quite expensive.
|
Thanks for the feedback @CompuIves - I've reverted the regex and run the contributor task. |
|
Thanks a lot! I'll deploy it now. |
Fixes #51