Remove all 'create-react-app-typescript' references

[MichaelDeBoey]

What kind of change does this PR introduce?
Code cleanup

What is the current behavior?
The code has references to create-react-app-typescript although we're using create-react-app --typescript

What is the new behavior?
All references to create-react-app-typescript are gone

Checklist:

• Documentation N/A
• Tests
• Ready to be merged
• Added myself to contributors table N/A

Closes #1014
Closes #1015

[SaraVieira]

I am actually not entirely sure about this so I asked ives to make sure

[MichaelDeBoey]

Yeah I think @CompuIves knows the most about everything related 🙂

[CompuIves]

I'm not sure if we can remove all the references yet, as there are still sandboxes that use create-react-app-typescript (https://codesandbox.io/search?refinementList%5Btemplate%5D%5B0%5D=create-react-app-typescript&page=1&configure%5BhitsPerPage%5D=12). A solution would be to convert all those to CRA, but we first need to make sure that the mapping of CRA-TS -> CRA is fluent.

[MichaelDeBoey]

Hmmmmm haven't thought about the ones that already exist... 😕

We could choose to convert all of those ourselves (automatically) to CRA or we could show some kind of notice that these ones aren't supported anymore and just convert them to a plain JS template? 🤔

@CompuIves Could you maybe give some more info what the meaning of the template is after I created a sandbox?
All the dependencies are in place after creation, so don't see any problems to just change the template to plain JS?

[MichaelDeBoey]

When @wmonk deprecated the create-react-app-typescript repo, he also added a link to @Vinnl's migration guide (which is also the recommended guide by the CRA-team) btw, so depending on the purpose of the template after creating a sandbox, this one could come in handy

[MichaelDeBoey]

@CompuIves Did you already have some time to look into my questions?

@CompuIves Could you maybe give some more info what the meaning of the template is after I created a sandbox?
All the dependencies are in place after creation, so don't see any problems to just change the template to plain JS?

[CompuIves]

Saw your questions now!

We could choose to convert all of those ourselves (automatically) to CRA or we could show some kind of notice that these ones aren't supported anymore and just convert them to a plain JS template? 🤔

I think there are some manual changes (like in the migration guide) that needs to be made. People can convert by themselves, but I don't like forcing them to use something new.

Could you maybe give some more info what the meaning of the template is after I created a sandbox?

Templates are primarily used to say to the browser bundler of CodeSandbox what to bundle. We're changing that now though, and it will soon just be used as boilerplate and custom colors. By that time we can start removing the references to create-react-app-typescript.

Templates used to have more logic, they used to define what files to add when you press "Export" and what linting rules to enable. We started to make that configurable though, and nowadays their functionality is primarily giving a starting point for new people tos tart.

[CompuIves]

I think we should wait a bit with removing the template until we've fully extracted all template specific logic. Then we'll know for sure that we won't break anything.

[MichaelDeBoey]

Seems a logical decision to wait a bit longer indeed.

If you can lead me towards the changes that need to happen first, I'm happy to contribute 🙂

[SaraVieira]

There is nothing we can do for now in terms of code I think :(

Or at least we didn't yet see a pathway to it

[CompuIves]

I think we can re-evaluate this once we start moving everything to custom templates!

[MichaelDeBoey]

Yeah sure no prob 🙂