Skip to content

fix(dashboard): prevent double click on editing #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2022
Merged

fix(dashboard): prevent double click on editing #6812

merged 3 commits into from
Aug 3, 2022

Conversation

danilowoz
Copy link
Member

@danilowoz danilowoz commented Aug 2, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

Screen.Recording.2022-08-02.at.12.12.20.mov

@danilowoz danilowoz requested a review from JamesACS August 2, 2022 10:36
@linear
Copy link

linear bot commented Aug 2, 2022

SPT-81 Bug: Mouse inputs aren't properly isolated during the folder renaming flow, leading to difficulty for mouse users

Issue affecting: Client

Escalation ID: https://app.frontapp.com/open/msg_lhbt98m

Github ID: #6437

Replay:

https://www.loom.com/share/edcdbddcc6e547c0b9f654f6edddcf5a

Priority: Low

Description:

  1. When you create a folder it automatically resorts by alphabetic (less an issue, but complex structures the folder vanishes)
  2. When you double click to select a word (to delete, copy, etc) it triggers the default event handler and opens the folder.
  3. When you right click to use the OS spellcheck it de-selects the input field meaning you can never use spell-check
  4. When the resort happens, it doesn't correctly store the names. When you attempt to rename a folder after adding one, (which triggers the resort) it show the name value of the folder that was in that position before the new folder was added

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 575ae85:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr6812 August 2, 2022 10:44 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Aug 2, 2022

Build for latest commit 575ae85 is at https://pr6812.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr6812 August 2, 2022 11:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants