Skip to content

feat(pro): UI updates #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 8, 2022
Merged

feat(pro): UI updates #7110

merged 13 commits into from
Nov 8, 2022

Conversation

olarclara
Copy link
Contributor

What kind of change does this PR introduce?

  • Extends the Badge component to accept more props.
  • Removes the Pro badge.
  • Adds the Free badge where appropriate.
  • Adds the link to team settings.
  • Removes unused code + organizes the folder.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Visit /pro.

@olarclara olarclara self-assigned this Nov 4, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 4, 2022

@linear
Copy link

linear bot commented Nov 4, 2022

XTD-307 Update page to upgrade to Pro

codesandbox.io/pro if you are not on a pro account, the view should look like the designs below. There are some missing features like

  • link to go to team setting
  • the free badge next to the team name
  • updated designs for the workspace selector dropdown

Designs

Subscription pages - Sign-up and Trial (Figma)

Current:

image.png

image.png

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51565e0:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr7110 November 4, 2022 19:51 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 4, 2022

Build for latest commit 51565e0 is at https://pr7110.build.csb.dev/s/new.

@olarclara olarclara changed the title feat(pro): ui updates feat(pro): UI updates Nov 4, 2022
Copy link
Contributor

@alexnm alexnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Disabled options in the select still have a weird extra padding that needs to be removed, other then that, it looks good. I would suggest some additional changes here, like not even showing the teams that are disabled, but we should merge this first and follow-up with an improvement ticket of the page for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants