Add tox.ini to the list of default config files
#2087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
64d0057 to
b6482d6
Compare
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
b6482d6 to
bee012e
Compare
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
bee012e to
cf28162
Compare
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
cf28162 to
762f803
Compare
peternewman
reviewed
Sep 11, 2022
There was a problem hiding this comment.
Looks fine in principle.
This does raise one interesting question, for backwards compatibility it would be nice if tox.ini (i.e. the new one) had the lowest priority. I don't currently know how that works, given it renders fake command line data, does --foo 1 --foo 2 mean that 1 or 2 wins, or we get both?
If we don't currently have a test for that we ought to add one (I don't know if you fancy trying that, feel free to do another PR), or I'll have a go. If we do, we should extend it to check tox.ini works too.
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
762f803 to
de24ff1
Compare
Because tox.ini is the latest addition to configuration files, it should have the lowest priority. List it last in the documentation, but use the reverse order in arguments of configparser.ConfigParser.read(), as I suspect this functions overwrites options from prior configuration files with options from subsequent configuration files.
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
de24ff1 to
c5bd285
Compare
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
c5bd285 to
5068d73
Compare
DimitriPapadopoulos
force-pushed
the
tox.ini
branch
from
5068d73 to
c5bd285
Compare
|
I think |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2086.