Heapsort

[HarsheetKakar]

References to other Issues or PRs or Relevant literature

Fixes #107

Brief description of what is fixed or changed

Used min heap to make heapsort.
Passes all tests.

Other comments

[codecov]

Codecov Report

Merging #243 into master will decrease coverage by 0.028%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #243       +/-   ##
=============================================
- Coverage   98.575%   98.546%   -0.029%     
=============================================
  Files           24        24               
  Lines         2106      2202       +96     
=============================================
+ Hits          2076      2170       +94     
- Misses          30        32        +2     

Impacted Files	Coverage Δ
pydatastructs/linear_data_structures/__init__.py	100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py	100.000% <100.000%> (ø)
pydatastructs/trees/__init__.py	100.000% <0.000%> (ø)
pydatastructs/trees/binary_trees.py	97.033% <0.000%> (+0.081%)	⬆️

[czgdp1807]

Please add doc strings as well.

[HarsheetKakar]

Should we add reverse parameter since there is no way to implement comp?

[czgdp1807]

Should we add reverse parameter since there is no way to implement comp?

Ignore this thing. The algorithm itself is fixed since it uses a fixed type of heap.

[HarsheetKakar]

Should we add reverse parameter since there is no way to implement comp?

Ignore this thing. The algorithm itself is fixed since it uses a fixed type of heap.

don't you think that comp should be added in heap also, since we already have a class attribute _comp inside DHeap

[czgdp1807]

don't you think that comp should be added in heap also, since we already have a class attribute _comp inside DHeap

I am not sure if accessing _comp from inside heaps will be a good idea as they are only there for combing the code for min and max heaps. We don't know how it will work for they inputs of heapsort. May be user passes _comp with some other kinds of input which are not compatible with heaps then it will create unpredictable problems.

[HarsheetKakar]

don't you think that comp should be added in heap also, since we already have a class attribute _comp inside DHeap

I am not sure if accessing _comp from inside heaps will be a good idea as they are only there for combing the code for min and max heaps. We don't know how it will work for they inputs of heapsort. May be user passes _comp with some other kinds of input which are not compatible with heaps then it will create unpredictable problems.

lets leave it then

[HarsheetKakar]

Is it ok to merge?

[HarsheetKakar]

anything to update in this? @czgdp1807